📦 Make @proconnect-gouv/proconnect.email publishable standalone#2017
Open
douglasduteil wants to merge 1 commit into
Open
📦 Make @proconnect-gouv/proconnect.email publishable standalone#2017douglasduteil wants to merge 1 commit into
douglasduteil wants to merge 1 commit into
Conversation
**Problem** The package built fine inside the monorepo but was unusable as a standalone npm dependency: tsc emitted extensionless relative imports under Bundler resolution, which plain Node ESM can't resolve (ERR_MODULE_NOT_FOUND). It was also still marked private, shipped src/tests/stories in the tarball, and listed a TS-only editor plugin as a runtime dependency. **Proposal** Switch module/moduleResolution to NodeNext and add explicit .js extensions to all relative imports (directory imports resolve to index.js). Flip private to false, scope the published tarball to dist via "files", and move @kitajs/ts-html-plugin to devDependencies. Verified by packing, installing the tarball into a clean throwaway Node project, and rendering a template with plain `node`.
douglasduteil
force-pushed
the
douglasduteil/Make-proconnect-gouv-proconnect.email-publishable-standalone
branch
from
f130a4b to
efb9b61
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The package built fine inside the monorepo but was unusable as a standalone npm dependency: tsc emitted extensionless relative imports under Bundler resolution, which plain Node ESM can't resolve (ERR_MODULE_NOT_FOUND). It was also still marked private, shipped src/tests/stories in the tarball, and listed a TS-only editor plugin as a runtime dependency.
Proposal
Switch module/moduleResolution to NodeNext and add explicit .js extensions to all relative imports (directory imports resolve to index.js). Flip private to false, scope the published tarball to dist via "files", and move @kitajs/ts-html-plugin to devDependencies. Verified by packing, installing the tarball into a clean throwaway Node project, and rendering a template with plain
node.